← Back to team overview

kicad-developers team mailing list archive

Re: [Patch] Update common preview items

 

All good from what I see. I appreciate the cleanup here to drop down to base classes where possible!

-Seth

On 2019-09-04 15:31, Wayne Stambaugh wrote:
This patch looks good to me.  Anyone else have any objections?

On 8/31/19 10:42 AM, Ian McInerney wrote:
Some preview items were still static casting into PCB_RENDER_SETTINGS
while others were using the base class version to get the layer colors.
This patch updates it so all calls are to the base class version, this
also removes the need to have pcb_painter (and any pcbnew includes) in
these files.

-Ian

_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


References