kicad-developers team mailing list archive
Mailing list archive
Re: [PATCH 0/2] Remove useless casts
On 2019-09-06 18:36, Simon Richter wrote:
I have two patches that remove useless casts. The first covers cases
it is quite obvious that the cast can be removed with no adverse
the second contains the cases where that is less clear.
In theory, both can be applied and should not cause code changes, but
second needs review to see if something else was originally intended by
I'm in favor of cleaning the casts as we code or if there's a specific
instance where the cast creates a problem (perhaps causing an unneeded
class instantiation). The large size of these patches without a clear
problem they are solving makes me leery that we will introduce a new
issue and I'd prefer to avoid this if possible.