kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #42115
Re: [Patch] Handle Cvpcb save actions immediately
-
To:
kicad-developers@xxxxxxxxxxxxxxxxxxx
-
From:
jp charras <jp.charras@xxxxxxxxxx>
-
Date:
Wed, 18 Sep 2019 10:37:56 +0200
-
In-reply-to:
<CACp=VfZ99G-_UVHnzP1tAHjdCAiQ9+S+HLm4--Pe+XfVLTGXXQ@mail.gmail.com>
-
Openpgp:
preference=signencrypt
-
User-agent:
Mozilla/5.0 (Windows NT 6.1; rv:60.0) Gecko/20100101 Thunderbird/60.9.0
Le 18/09/2019 à 10:13, Ian McInerney a écrit :
> Ping.
>
> On Mon, Sep 9, 2019 at 7:05 AM Ian McInerney <Ian.S.McInerney@xxxxxxxx
> <mailto:Ian.S.McInerney@xxxxxxxx>> wrote:
>
> This patch updates Cvpcb to run the save actions immediately when
> the buttons are pressed. If they are not run immediately, then the
> user may see the handle unsaved changes dialog (which if they
> clicked on OK is not what they are expecting), which will allow them
> to veto the close event. The event generated by the OK button is
> non-vetoable though, so showing this dialog can lead to an assertion.
>
> -Ian
>
I forgot your patch in my commit 9ceca583.
I committed you fix.
Thanks.
--
Jean-Pierre CHARRAS
References