kicad-developers team mailing list archive

[Jeff Young <jeff@xxxxxxxxx>]

+1


> On 18 Sep 2019, at 14:25, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
> 
> I think we should merge it.  I tested it on a new config and my crufty
> old config and it seems to work as expected.  There may be some issues
> for users with multiple actions defined to the same key but that should
> be a simple matter of having them reset their key assignment to the
> default.  If there are no objections, I have this queued up and ready to
> merge.
> 
> Cheers,
> 
> Wayne
> 
> On 9/18/19 4:13 AM, Ian McInerney wrote:
>> What do we want to do with this patch?
>> 
>> -Ian
>> 
>> On Fri, Sep 6, 2019 at 1:23 AM Seth Hillbrand <seth@xxxxxxxxxxxxx <mailto:seth@xxxxxxxxxxxxx>
>> <mailto:seth@xxxxxxxxxxxxx <mailto:seth@xxxxxxxxxxxxx>>> wrote:
>> 
>>    Wow, this bug has been a real annoyance for some time.  Thank you for
>>    tracking down the origin.
>> 
>>    I've tested Ian's patch and it works correctly.  Allows the 'P' hotkey
>>    to correctly trigger the Place Power action in eeschema and the Create
>>    Pin action in LibEdit.  Tested with individual applications as well as
>>    with both applications running at the same time.
>> 
>>    Note, however, that when we edit the hotkeys in preferences, no such
>>    testing of whether a hotkey is handled takes place and we simply show a
>>    warning that the 'P' hotkey is bound to two separate actions.  I'm not
>>    sure what the course of action here could be other than to separate
>>    testing of the hotkey overlap between applications.
>> 
>>    -Seth
>> 
>>    On 2019-09-05 17:21, Ian McInerney wrote:
>>> This somehow got lost in my email, but I have now found a case where
>>> this
>>> is needed in the "wild" (the master branch). For bug
>>> https://bugs.launchpad.net/kicad/+bug/1834547 <https://bugs.launchpad.net/kicad/+bug/1834547>, it appears that on
>>    Linux
>>> the
>>> hotkey architecture is trying to run the action for place symbol pin
>>> instead of the place power action. These two actions are never active
>>> on
>>> the same editing session, so it is a valid configuration. Applying
>>    this
>>> patch fixes the behavior, and the place power symbol action is
>>    actually
>>> called.
>>> 
>>> -Ian
>>> 
>>> On Mon, Aug 12, 2019 at 9:02 PM Wayne Stambaugh
>>    <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx> <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>>
>>> wrote:
>>> 
>>>> What is the status of this patch?
>>>> 
>>>> Cheers,
>>>> 
>>>> Wayne
>>>> 
>>>> On 8/8/19 7:16 PM, Ian McInerney wrote:
>>>>> In the current framework, if more than one global actions share
>>    the same
>>>>> hotkey (even if they are not all active in the current tool
>>    manager),
>>>>> the dispatcher will only choose the final action (in what seems
>>    to be
>>>>> alphabetical order) to run. I think that the correct behavior
>>    should
>>>>> instead be to loop through all global actions that have the
>>    hotkey until
>>>>> one handles it.
>>>>> 
>>>>> The attached patch implements this change.
>>>>> 
>>>>> -Ian
>>>>> 
>>>>> _______________________________________________
>>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>    <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>>>>> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>>>> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
>>>>> 
>>>> 
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>    <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>>>> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>>> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
>>>> 
>>> 
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>    <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp