kicad-developers team mailing list archive

[Zficani Zficani <zifcani@xxxxxxxxx>]

Hi,
I see, I will send in new patches later today. Do I just send them in an
email like this?

On Fri, 11 Oct 2019, 02:10 Seth Hillbrand, <seth@xxxxxxxxxxxxx> wrote:

>
> On 2019-10-09 17:08, Zficani Zficani wrote:
>
> Hi,
> it's been about 10 days since my message so I just want to make sure I
> sent it properly and you noticed it because I'm not sure as I'd want to be
> able to actually use this feature soon because it's very useful for me.
>
> Thank you.
>
> On Sun, Sep 29, 2019 at 11:55 PM Zficani Zficani <zifcani@xxxxxxxxx>
> wrote:
>
>> Hi,
>> I reviewed your remarks and made appropriate changes but I have a few
>> questions.
>> Regarding your first remark, I had to make them non-reference because
>> the selection is sorted inplace which means that the original selection
>> will be modified which in turn make unhighlight hang/enter and infinite
>> loop when copying/duplicating or just unhighlighting multiple objects.
>> I'm not sure why exactly this is happening but it obviously has
>> something to do with the fact that selection is now sorted by
>> reference.
>>
>> I did change the code according to the second and third remark though
>> and will send in the patches later (it's currently available on
>>
>> https://github.com/Nufflee/kicad-source-mirror/tree/1335616-annotate-on-placement
>> if anyone wants to take a look).
>>
>>
>>
> Hi Zficani-
>
>
> I can't speak for others but I was waiting for either a patch with the
> revised code or a merge request on launchpad.  I like the idea of your
> feature and look forward to helping get it into merge shape.  I agree with
> Ian's comments and was hoping to see how you address them.
>
>
> Best-
>
> Seth
>
>
> Seth Hillbrand
>
> Chief Technologist
>
> KiCad Services Corporation
> Twitter [image: Twitter] <https://twitter.com/KiProEDA>   LinkedIn [image:
> LinkedIn] <https://www.linkedin.com/company/kicad/about>
> +1 530 302 5483 <+15303025483> | +1 212 603 9372 <+12126039372>
> www.kipro-pcb.com
> Davis, CA
>