kicad-developers team mailing list archive

[Jonatan Liljedahl <lijon@xxxxxxxxxxxx>]

Ok, now I think I've followed the policies correctly, here's the updated patch.

Cheers

On Wed, Nov 6, 2019 at 10:33 PM Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>
> Hi Jonathon,
>
> I tested your original patch on the 5.1 branch and it seems to work as
> advertised.  It would be nice if there was a way to query ngspice for a
> list of vectors rather than using just the net list to populate add
> signals dialog.  Maybe Holger can weigh in on this.
>
> Before you submit your updated patch, please fix your code formatting to
> follow the KiCad Coding Policy[1] and your commit message to follow the
> KiCad Commit Message[2] policy.  There is a git commit hook[3] to help
> you with coding policy issues.  I saw some K&R curly brace placement in
> your patch.
>
> Thanks,
>
> Wayne
>
> [1]:
> http://docs.kicad-pcb.org/doxygen/md_Documentation_development_coding-style-policy.html
> [2]: http://docs.kicad-pcb.org/doxygen/commit_messages.html
> [3]:
> http://docs.kicad-pcb.org/doxygen/md_Documentation_development_coding-style-policy.html#tools
>
> On 11/6/19 4:06 PM, Jonatan Liljedahl wrote:
> > This patch does not implement all of pt 4 in that bug report, it only
> > allows adding plots of vectors by name, including vectors created by
> > LET statements in a spice text block in the schematic (which are not
> > listed in the signals list, since that list is based on the net names,
> > not the existing spice vectors).
> >
> > However, I just realized that there's a problem with my patch, it only
> > works for V, not I. I'll take a look and update my patch.
> >
> > On Wed, Nov 6, 2019 at 9:08 PM Sylwester Kocjan <s.kocjan@xxxxx> wrote:
> >>
> >> Hi Jonatan,
> >>
> >> On 06/11/2019 13:29, Jonatan Liljedahl wrote:
> >>> useful for plotting calculated vectors ("let AB=V(a)*V(b)"),
> >>> see for example
> >>> https://forum.kicad.info/t/ac-analysis-of-op-amp-loop-gain-and-phase/19661/6
> >>>
> >>
> >> Just small remark to limit entropy in bug reports: it looks like you
> >> have implemented pt. 4 from:
> >>
> >> https://bugs.launchpad.net/kicad/+bug/1814188
> >>
> >> Maybe it's worth to update that bug report if it will be merged.
> >>
> >> Best regards,
> >> Sylwester
> >>
> >> _______________________________________________
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp
> >
> >
> >
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp



-- 
/Jonatan
http://kymatica.com

Attachment: 0001-Eeschema-simulation-allow-adding-signals-by-name-lik.patch
Description: Binary data