← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Three new source types added to DIALOG_SPICE_MODEL

 

Hi Wayne,

Thanks!

Yes it is! It was merged in the GH PR I sent above, and is currently at
https://github.com/KiCad/kicad-symbols and mirrored at
http://kicad-pcb.org/libraries/download/ from the main KiCad website. So
you can merge to 5.1.

Would it be accepted if I updated the existing demo projects with symbols
from this lib instead of the "unique" symbols used in the demo projects now?

On Wed, Nov 13, 2019 at 1:18 PM Wayne Stambaugh <stambaughw@xxxxxxxxx>
wrote:

> Hi Evan,
>
> I merged your patch into the master branch.  Thank you for your
> contribution to KiCad.  Just out of curiosity, is the Simulation_SPICE
> library shipped with the 5.1 build?  If so, I can merger this demo into
> the 5.1 branch.  Users might find it useful to demo the sources provided
> by this library.  If not, then there is no reason to merge it into 5.1.
>
> Cheers,
>
> Wayne
>
> On 11/12/19 2:55 PM, Evan Shultz wrote:
> > Hi Wayne,
> >
> > Attached is the patch for the new V and I source simulation demo project
> > I mentioned. For reference, it was initially posted
> > at https://github.com/KiCad/kicad-symbols/pull/1473.
> >
> > If you like, I can also update the existing simulation demos with
> > 'standard' library components in the Simulation_SPICE directory instead
> > of the 'one-off' symbols used now.
> >
> > Sorry for the hijacking.
> >
> > Evan
> >
> > On Tue, Nov 5, 2019 at 5:31 AM Wayne Stambaugh <stambaughw@xxxxxxxxx
> > <mailto:stambaughw@xxxxxxxxx>> wrote:
> >
> >     Hi Even,
> >
> >     I was cleaning my inbox and I noticed I hadn't commented on your
> >     request.  If you have a demo project that utilizes the spice library
> >     changes you made, I would be more than happy to include it in master.
> >     Please send a patch with demo project and I will merge it after I've
> >     tested it and made any comments.
> >
> >     Cheers,
> >
> >     Wayne
> >
> >     On 10/23/19 3:55 PM, Evan Shultz wrote:
> >     > Hi,
> >     >
> >     > Apologies for the slight tangent...
> >     >
> >     > When I submitted symbols for all V and I sources supported by
> ngspice
> >     > at https://github.com/KiCad/kicad-symbols/pull/1473, I created a
> >     > simulation schematic to show off their output waveforms. Some of
> them
> >     > can use the source control features here. I thought this might be
> >     > helpful when testing this patch
> >     >
> >     > It may also be useful to include the SPICE source simulation as a
> >     demo.
> >     > If so, should I make a bug on launchpad?
> >     >
> >     > On Sun, Oct 20, 2019 at 2:00 PM Sylwester Kocjan <s.kocjan@xxxxx
> >     <mailto:s.kocjan@xxxxx>
> >     > <mailto:s.kocjan@xxxxx <mailto:s.kocjan@xxxxx>>> wrote:
> >     >
> >     >     On 20/10/2019 20:53, Seth Hillbrand wrote:
> >     >     > On 2019-10-20 08:36, Sylwester Kocjan wrote:
> >     >     >> Hi,
> >     >     >>
> >     >     >> Here is a patch with three additional source models
> >     implemented:
> >     >     SFFM,
> >     >     >> AM and Random.
> >     >     >>
> >     >     >> I hope this looks ok, cause I had troubles with configuring
> >     >     >> clang-format on Windows. If no, I can correct.
> >     >     >>
> >     >     >> Best regards,
> >     >     >> Sylwester
> >     >     >>
> >     >     >> _______________________________________________
> >     >     >> Mailing list: https://launchpad.net/~kicad-developers
> >     >     >> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
> >     >     >> Unsubscribe : https://launchpad.net/~kicad-developers
> >     >     >> More help   : https://help.launchpad.net/ListHelp
> >     >     >
> >     >     > Hi Sylwester-
> >     >     >
> >     >     > There is something odd with your patch.  See the attached
> >     >     screenshot.  I
> >     >     > cannot apply this to test as there are a number of unknown
> >     >     characters at
> >     >     > the end of lines and the end of the file.
> >     >     >
> >     >     > -Seth
> >     >     >
> >     >     > Seth Hillbrand
> >     >     > KiCad Services Corporation
> >     >     > https://www.kipro-pcb.com
> >     >     > +1 530 302 5483 | +1 212 603 9372
> >     >
> >     >     Hi Seth,
> >     >
> >     >     You are right, this patch is quite big and was truncated by
> mail
> >     >     servers, something gone wrong during sending mail. I've put it
> to
> >     >     google
> >     >     drive:
> >     >
> >     >
> >
> https://drive.google.com/file/d/1x_YDsIw6FhgJFEsDgteEl5L5PGwSsCiz/view?usp=sharing
> >     >
> >     >
> >     >     Best regards,
> >     >     Sylwester
> >     >
> >     >     _______________________________________________
> >     >     Mailing list: https://launchpad.net/~kicad-developers
> >     >     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
> >     >     Unsubscribe : https://launchpad.net/~kicad-developers
> >     >     More help   : https://help.launchpad.net/ListHelp
> >     >
> >     >
> >     > _______________________________________________
> >     > Mailing list: https://launchpad.net/~kicad-developers
> >     > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >     > Unsubscribe : https://launchpad.net/~kicad-developers
> >     > More help   : https://help.launchpad.net/ListHelp
> >     >
> >
> >     _______________________________________________
> >     Mailing list: https://launchpad.net/~kicad-developers
> >     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >     Unsubscribe : https://launchpad.net/~kicad-developers
> >     More help   : https://help.launchpad.net/ListHelp
> >
>

Follow ups

References