← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Kicad: project manager: Do not reconstruct entire project tree when renaming file to different dir

 

I'll give it a test on GTK once my build here finishes, but I don't think I
have seen any issues with file watcher on GTK in the past.

-Ian

On Fri, Nov 15, 2019 at 10:03 PM Jeff Young <jeff@xxxxxxxxx> wrote:

> Hi Mikolaj,
>
> The Mac compiler doesn’t like Rename() returning values when the return
> type is void.  However, after fixing that it works fine on Mac.
>
> I remember however something about the file watcher not working on all
> platforms.  I thought the problem platform was Windows, though, so maybe
> I’m not remembering it correctly (as you’re on Windows, right?).
>
> Can someone validate that this works on GTK?
>
> Cheers,
> Jeff.
>
>
> On 15 Nov 2019, at 21:05, Mikołaj Wielgus <wielgusmikolaj@xxxxxxxxx>
> wrote:
>
> Hi,
>
> Renaming file to a different directory causes the entire project tree to
> be recreated, which causes all subdirectories to collapse, unexpectedly to
> the user.
>
> This patch solves the problem by deleting the original node after moving
> the file. Then the file watcher raises an event whose handler constructs a
> new node in the new location.
>
> This issue comes from the fix to this bug:
> https://bugs.launchpad.net/kicad/+bug/1852431
>
> Best Regards,
> Mikołaj Wielgus
> <0001-Do-not-reconstruct-proj-tree-on-rename-to-diff-dir.patch>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Follow ups

References