← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Eeschema: simulator plot: allow standard mac pan and pinch to zoom

 

Hi,

I found it. Here's an updated patch that makes it behave exactly as in
the schematic editor, and uses the "trackpad pan" common config
setting. This should work as expected on Linux.

Note that in mathplot.h the coding style git hook complained, but I
left it as is because it matches the current style in mathplot.h.
Better to update the coding style for the whole file in a separate
commit.

Cheers

On Thu, Nov 21, 2019 at 7:13 PM Kymatica <j.r.liljedahl@xxxxxxxxx> wrote:
>
> It changes to ctrl-scrollwheel for zooming. Perhaps someone can point me in the right direction for having the correct behavior on linux? How is it done in the schematic editor?
>
> /Jonatan
>
> > 21 nov. 2019 kl. 18:02 skrev Wayne Stambaugh <stambaughw@xxxxxxxxx>:
> >
> > Hi Jonatan,
> >
> > I tested this patch on my Linux laptop which has Ubuntu 19.04 with a
> > stock gnome desktop and it breaks the two finger zoom touchpad behavior.
> > With your patch zoom becomes a pan.  I'm not sure if this is just a
> > configuration issue or something else but I'm not seeing the same
> > behavior in the board and schematic editors so I suspect something else
> > is at play.  Can someone else with a linux laptop test this?  I don't
> > want to merge this if it breaks linux systems.
> >
> > Cheers,
> >
> > Wayne
> >
> >> On 11/19/19 11:22 AM, Jonatan Liljedahl wrote:
> >> This patch allows standard trackpad gestures for pan and zoom, just
> >> like in eeschema and pcbnew etc.
> >>
> >> While working on this, I noticed mathplot.cpp is a bit messy, with a
> >> lot of commented out or unused code, and some buggy behaviours. This
> >> patch does not address any of that.
> >>
> >>
> >> _______________________________________________
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp
> >>
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp



-- 
/Jonatan
http://kymatica.com

Attachment: 0001-Eeschema-simulator-plot-allow-standard-mac-pan-and-p.patch
Description: Binary data


Follow ups

References