kicad-developers team mailing list archive

[Carsten Schoenert <c.schoenert@xxxxxxxxxxx>]

Hello Ian,

On 28.11.19 17:53, Ian McInerney wrote:
> I would like to change the way we generate the kicad.appdata.xml file to
> have it be generated by CMake and include the version string inside of
> it (that way the version will appear in the app stores and other places
> that reference this). I don't think this will cause any issues, but I
> just want to see if anyone sees any problems with this.

this can't be a problem as the AppStream specification is holding a key
for versioning information. Please see section 4.1.2, <releases> ...
</releases>

> https://www.freedesktop.org/software/appstream/docs/chap-Quickstart.html#sect-Quickstart-DesktopApps

If you touch this all I'd suggest to update all URLs within the appdata
file as now the kicad-pcb.org domain is served by https.

> $ git diff
> diff --git a/resources/linux/appdata/kicad.appdata.xml b/resources/linux/appdata/kicad.appdata.xml
> index 2fc29f0c1..550cb10c5 100644
> --- a/resources/linux/appdata/kicad.appdata.xml
> +++ b/resources/linux/appdata/kicad.appdata.xml
> @@ -46,27 +46,27 @@
>  
>    <screenshots>
>      <screenshot type="default">
> -      <image width="1024" height="576">http://kicad-pcb.org/img/screenshots/appstream/kicad.png</image>
> +      <image width="1024" height="576">https://kicad-pcb.org/img/screenshots/appstream/kicad.png</image>
>      </screenshot>
>  
>      <screenshot>
>        <caption>Eeschema Schematic Editor</caption>
> -      <image width="1024" height="576">http://kicad-pcb.org/img/screenshots/appstream/eeschema.png</image>
> +      <image width="1024" height="576">https://kicad-pcb.org/img/screenshots/appstream/eeschema.png</image>
>      </screenshot>
>  
>      <screenshot>
>        <caption>PcbNew PCB Layout</caption>
> -      <image width="1024" height="576">http://kicad-pcb.org/img/screenshots/appstream/pcbnew.png</image>
> +      <image width="1024" height="576">https://kicad-pcb.org/img/screenshots/appstream/pcbnew.png</image>
>      </screenshot>
>  
>      <screenshot>
>        <caption>PcbNew 3D Viewer</caption>
> -      <image width="1024" height="576">http://kicad-pcb.org/img/screenshots/appstream/3dviewer.png</image>
> +      <image width="1024" height="576">https://kicad-pcb.org/img/screenshots/appstream/3dviewer.png</image>
>      </screenshot>
>    </screenshots>
>  
> -  <url type="homepage">http://kicad-pcb.org/</url>
> -  <url type="bugtracker">http://kicad-pcb.org/help/report-a-bug/</url>
> +  <url type="homepage">https://kicad-pcb.org/</url>
> +  <url type="bugtracker">https://kicad-pcb.org/help/report-a-bug/</url>
>    <update_contact>kicad-developers@xxxxxxxxxxxxxxxxxxx</update_contact>
>    <developer_name>The KiCad Developers</developer_name>
>  </component>

This reminds me that all the screenshots should be updated too. ;)

The validator for the AppData content within the Debian QA is mentioning
that the component ID is not a reverse domain-name. Should get fixed too
in case the file is getting changed.

> https://appstream.debian.org/sid/main/issues/kicad.html

-- 
Regards
Carsten Schoenert