kicad-developers team mailing list archive
Mailing list archive
Re: Coverity finds an ugly bug in wxWidgets
In this case we should just need to clarify the scope (which I just pushed
a fix doing). In general... I am not as sure about.
On Sat, Jan 11, 2020 at 9:28 PM Jeff Young <jeff@xxxxxxxxx> wrote:
> This looks safe enough:
> if( n_changed )
> wxLogTrace( "CN", "Cluster %p : net : %d %s\n", cluster.get(),
> cluster->OriginNet(), (const char*) cluster->OriginNetName().c_str() );
> wxLogTrace( "CN", "Cluster %p : nothing to propagate\n", cluster.get() );
> Sadly, the macro wxLogTrace is not parenthesized, and starts with an if
> statement. So the else doesn’t go where you think it does….
> Any ideas on how to fix this that don’t include constantly checking to see
> if new instances have been introduced?
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp