kicad-developers team mailing list archive

[Jon Evans <jon@xxxxxxxxxxxxx>]

Wayne, can you revert the changes on lines 343-347 and add back -DDEBUG to
those four locations, keeping the added part around line 173 of the
CMakeLists.txt?

If that fixes it, it tells us that for some reason the set_property call is
not resulting in the -DDEBUG making it into the makefiles on your system.

(see:
https://gitlab.com/kicad/code/kicad/commit/b824051adf246c6d5d30a1a5806dd7a194f23700#9a2aa4db38d3115ed60da621e012c0efc0172aae_339_343
)

-Jon

On Fri, Feb 7, 2020 at 12:29 PM Jon Evans <jon@xxxxxxxxxxxxx> wrote:

> At the moment I only have access to my Mac, and can confirm that -DDEBUG
> does get added to my build file although it doesn't show as a variable in
> CMakeCache.txt
>
> I use ninja so I see it in the build lines of the build.ninja file
>
> Can you confirm if your makefile has -DDEBUG set or not for the compile
> commands somewhere?
>
> Does anyone else see this issue?
>
> On Fri, Feb 7, 2020 at 12:26 PM Wayne Stambaugh <stambaughw@xxxxxxxxx>
> wrote:
>
>> Neither `make rebuild_cache` or a clean build fixed the issue.  Attached
>> is the CMakeCache.txt file.
>>
>> On 2/7/20 11:50 AM, Jon Evans wrote:
>> > LIB_ID::Test is hidden behind a DEBUG ifdef check.  So, it seems like in
>> > your configuration the CMake change is not setting DEBUG anymore.
>> > Are you able to inspect your CMakeCache.txt to shed some light on this?
>> >
>> >
>> > On Fri, Feb 7, 2020 at 11:46 AM Wayne Stambaugh <stambaughw@xxxxxxxxx
>> > <mailto:stambaughw@xxxxxxxxx>> wrote:
>> >
>> >     I'm running into this build failure on my Debian Bullseye box as of
>> the
>> >     latest commits to the master branch:
>> >
>> >     /usr/bin/ld:
>> >
>>  ../../pcbnew/CMakeFiles/pcbnew_kiface_objects.dir/pcbnew_wrap.cxx.o: in
>> >     function `_wrap_LIB_ID_Test':
>> >
>>  /home/wayne/build/kicad/trunk-debug-gtk3-python/pcbnew/pcbnew_wrap.cxx:53313:
>> >     undefined reference to `LIB_ID::Test()'
>> >     collect2: error: ld returned 1 exit status
>> >     make[2]: ***
>> >     [qa/pcbnew_tools/CMakeFiles/qa_pcbnew_tools.dir/build.make:686:
>> >     qa/pcbnew_tools/qa_pcbnew_tools] Error 1
>> >     make[1]: *** [CMakeFiles/Makefile2:4612:
>> >     qa/pcbnew_tools/CMakeFiles/qa_pcbnew_tools.dir/all] Error 2
>> >     make[1]: *** Waiting for unfinished jobs....
>> >     /usr/bin/ld:
>> >
>>  ../../pcbnew/CMakeFiles/pcbnew_kiface_objects.dir/pcbnew_wrap.cxx.o: in
>> >     function `_wrap_LIB_ID_Test':
>> >
>>  /home/wayne/build/kicad/trunk-debug-gtk3-python/pcbnew/pcbnew_wrap.cxx:53313:
>> >     undefined reference to `LIB_ID::Test()'
>> >     collect2: error: ld returned 1 exit status
>> >     make[2]: *** [qa/pcbnew/CMakeFiles/qa_pcbnew.dir/build.make:792:
>> >     qa/pcbnew/qa_pcbnew] Error 1
>> >     make[1]: *** [CMakeFiles/Makefile2:4306:
>> >     qa/pcbnew/CMakeFiles/qa_pcbnew.dir/all] Error 2
>> >     make: *** [Makefile:163: all] Error 2
>> >
>> >     Git bisect blames commit b824051adf246c6d5d30a1a5806dd7a194f23700
>> as the
>> >     culprit.  If someone could fix this, I would appreciate at it.  I
>> can
>> >     file an issue on GitLab if its helpful.
>> >
>> >     Cheers,
>> >
>> >     Wayne
>> >
>> >     _______________________________________________
>> >     Mailing list: https://launchpad.net/~kicad-developers
>> >     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>> >     Unsubscribe : https://launchpad.net/~kicad-developers
>> >     More help   : https://help.launchpad.net/ListHelp
>> >
>>
>