kicad-developers team mailing list archive

[Ian McInerney <Ian.S.McInerney@xxxxxxxx>]

On Sun, Apr 5, 2020 at 12:05 PM Carsten Schoenert <c.schoenert@xxxxxxxxxxx>
wrote:

> Am 05.04.20 um 11:25 schrieb jp charras:
> > I just removed the I18N mark of strings used in debug messages.
>
> Thanks, seems you have missed some of them?
>
> > pcbnew/altium2kicadpcb_plugin/altium_parser.cpp:        THROW_IO_ERROR(
> _( "stream too large" ) );
>

I think this string is presented to the user if the importer throws this
error. I agree that it might not make much sense as an error (but I see
that it is being removed in the next set of bugfixes for the importer).


>
> > pcbnew/altium2kicadpcb_plugin/altium_pcb.cpp:
> wxString::Format( _( "No text position present for leader dimension object"
> ) ) );
>
> For the latter I'm not sure, but wxLogError looks not like it's some
> string for the UI. Nitpick, it's not a sentence, the leading sentence
> terminator is missing.
>
> --
> Regards
> Carsten Schoenert
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>