← Back to team overview

kicad-developers team mailing list archive

Re: DRC changes

 

In my simple test, the round-off errors are no longer an issue.

But I don’t have that exact footprint.  Could someone make the testcase (which fails on master) and send me the project + board?

Thanks,
Jeff.


> On 26 Apr 2020, at 16:58, Ian McInerney <Ian.S.McInerney@xxxxxxxx> wrote:
> 
> Is it still subject to the round-off errors (https://gitlab.com/kicad/code/kicad/-/issues/4139 <https://gitlab.com/kicad/code/kicad/-/issues/4139>)?
> 
> -Ian
> 
> On Sun, Apr 26, 2020 at 4:30 PM Jeff Young <jeff@xxxxxxxxx <mailto:jeff@xxxxxxxxx>> wrote:
> New bits up here: https://gitlab.com/kicad/code/kicad/-/merge_requests/193 <https://gitlab.com/kicad/code/kicad/-/merge_requests/193>
> 
> I claim this fixes the rotation problems and should markedly improve performance.
> 
> Cheers,
> Jeff.
> 
> 
>> On 26 Apr 2020, at 15:48, Jeff Young <jeff@xxxxxxxxx <mailto:jeff@xxxxxxxxx>> wrote:
>> 
>> Yeah, rotated rectangles report negative clearances too….
>> 
>>> On 26 Apr 2020, at 15:40, Jeff Young <jeff@xxxxxxxxx <mailto:jeff@xxxxxxxxx>> wrote:
>>> 
>>> Cool, I’ll look into that.
>>> 
>>> I’ve also got some performance improvements to upload.
>>> 
>>> Cheers,
>>> Jeff.
>>> 
>>>> On 26 Apr 2020, at 15:35, jp charras <jp.charras@xxxxxxxxxx <mailto:jp.charras@xxxxxxxxxx>> wrote:
>>>> 
>>>> Le 26/04/2020 à 16:15, Jeff Young a écrit :
>>>>> Hi JP,
>>>>> 
>>>>> Did they report the same number of errors?
>>>>> 
>>>>> Thanks,
>>>>> Jeff.
>>>>> 
>>>> 
>>>> No:
>>>> The old algo reports 0 error.
>>>> The new reports a lot.
>>>> I am thinking there is an issue with rectangular or round/rect pads rotated by +- 90 deg.
>>>> 
>>>> 
>>>> -- 
>>>> Jean-Pierre CHARRAS
>>>> 
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>>> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>>> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
>>> 
>>> 
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
>> 
>> 
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>


References