kicad-developers team mailing list archive

[Brian Piccioni <brian@xxxxxxxxxxxxxxxxxxxxx>]

Gabriel

Thank you for the reply!

I am using Windows 10/MSYS2 64/Eclipse.

I think the important part is MSYS2 since it really seems to be 
something between clang-format and git. I believe I followed the kicad 
instructions to set up clang-format exactly

In my kicad source directory I entered

git config core.hooksPath .githooks
git config clangFormat.style file
git config kicad.check-format true

And didn't get any errors.

Yet I have got all sorts of feedback that my code doesn't seem to follow 
the kicad clang-format standards with respect to the things it should catch.

I looked into this a while ago and asked but got no replies. I assume 
clang-format isn't doing its job.

I am happy to fix whatever issues they are, even manually if I have to.

But I need feedback for that ...

Brian






On 2020-05-10 12:20 p.m., Gabriel Staples, ElectricRCAircraftGuy.com wrote:
> Brian,
>
> I'd like to help you get clang-format working if possible. What OS are 
> you on? Do these install instructions help? I haven't looked at any 
> instructions for KICAD but I wrote these for another project I 
> contribute to:
>
> https://github.com/AmboVent-1690-108/AmboVent/blob/master/README.md#software
>
>
> Thanks!
>
> Gabriel Staples
> Electric RC Aircraft Guy, LLC
> www.ElectricRCAircraftGuy.com <http://www.ElectricRCAircraftGuy.com>
>
> Check out my "Computa Pranksta" USB device sold on Amazon!
>
> (sent from my Android)
>
> Le dim. 10 mai 2020 à 8:51 AM, Brian Piccioni 
> <brian@xxxxxxxxxxxxxxxxxxxxx <mailto:brian@xxxxxxxxxxxxxxxxxxxxx>> a 
> écrit :
>
>     Hello
>
>     I managed to update my Merge Request
>     (https://gitlab.com/kicad/code/kicad/-/merge_requests/108) to master
>     without any GIT screw ups.
>
>     The only change I had to make to the code was the name of the PCBNew
>     configuration method.
>
>     It compiles and runs.
>
>     I have been using this for some time without any issues. I am sure
>     there
>     are style problems since I can't get clang-format to work.
>
>     That said, I'd appreciate feedback or some idea when this might be
>     merged.
>
>     I know everybody is busy with COVID, etc., but things seem to be more
>     active nowadays.
>
>
>     Thanks
>
>     Brian
>
>
>     _______________________________________________
>     Mailing list: https://launchpad.net/~kicad-developers
>     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     Unsubscribe : https://launchpad.net/~kicad-developers
>     More help   : https://help.launchpad.net/ListHelp