kicad-developers team mailing list archive

[Roberto Fernández Bautista <roberto.fer.bau@xxxxxxxxx>]

(oops forgot to copy the mailing list)

Here is the merge request:
https://gitlab.com/kicad/code/kicad/-/merge_requests/322


On Fri, 31 Jul 2020 at 18:25, Seth Hillbrand <seth@xxxxxxxxxxxxx> wrote:

> Yes, please if you have time.  Otherwise, I'll get to it eventually from
> the diff but it might take some time.
>
> -S
>
> On Fri, Jul 31, 2020 at 10:24 AM Roberto Fernández Bautista <
> roberto.fer.bau@xxxxxxxxx> wrote:
>
>> Dear Seth,
>>
>> Okay I will do in the future. I thought it wasn't worth an MR due to only
>> 7 lines being changed, but I take your point.
>>
>> Shall I go ahead and create a merge request or are you happy to commit?
>>
>> Thanks.
>>
>> Roberto
>>
>


>>
>> On Fri, 31 Jul 2020 at 18:05, Seth Hillbrand <seth@xxxxxxxxxxxxx> wrote:
>>
>>> Hi Roberto-
>>>
>>> Thank you for the diff.  In the future, can you please create a MR for
>>> all source changes.  This keeps it part of our standard formatting/test
>>> suite checks.
>>>
>>> Best-
>>> Seth
>>>
>>>
>>> On Fri, Jul 31, 2020 at 7:44 AM Roberto Fernández Bautista <
>>> roberto.fer.bau@xxxxxxxxx> wrote:
>>>
>>>> Hi all,
>>>>
>>>> I just tried compiling from master and seems there is a bug in commits
>>>> 577c1be3, 128ae8b4 &  bd19892c .  I am building in MSVC (Windows 10) using
>>>> Jon's CMakeSettings.json configuration file (with modified file paths),
>>>> using the "x64-Debug" configuration.
>>>>
>>>>
>>>> It seems this was a simple fix. See attached diff that fixed the
>>>> compile errors for me. Could someone with commit rights please review and
>>>> push the attached diff if happy?
>>>>
>>>> Extract below of locations of the compile errors:
>>>>
>>>> *Commit  577c1be3  *
>>>> --- pcbnew/dialogs/panel_setup_rules.cpp line 262 ---
>>>>         line = (int) strtol( parts[0], nullptr, 10 );
>>>>         offset = (int) strtol( parts[1], nullptr, 10 );
>>>> --- end ---
>>>>
>>>>
>>>> Error C2664 'long strtol(const char *,char **,int)': cannot convert
>>>> argument 1 from '_Ty' to 'const char *'
>>>> C:\MySources\kicad\build\x64-Debug\kicad
>>>> C:\MySources\kicad\pcbnew\dialogs\panel_setup_rules.cpp 262
>>>> Error C2664 'long strtol(const char *,char **,int)': cannot convert
>>>> argument 1 from '_Ty' to 'const char *'
>>>> C:\MySources\kicad\build\x64-Debug\kicad
>>>> C:\MySources\kicad\pcbnew\dialogs\panel_setup_rules.cpp 263
>>>>
>>>> *Commits 128aeb4 & bd19892c*
>>>>
>>>> --- qa/drc_proto/drc_engine.cpp line 245 ---
>>>>
>>>>             drc_dbg(8, "   -> check condition '%s'\n", (const char*)
>>>> condition->m_Expression );
>>>>
>>>>             bool result = condition->EvaluateFor( a, b );
>>>>             if( result )
>>>>             {
>>>>                 drc_dbg(8, "   -> rule '%s' matches, triggered by
>>>> condition '%s'\n", (const char*) rcond->rule->m_Name.c_str(), (const char*)
>>>> condition->m_Expression );
>>>>                 return rcond->rule;
>>>>             }
>>>>
>>>> --- end ---
>>>>
>>>> Error C2440 'type cast': cannot convert from 'wxString' to 'const char
>>>> *' C:\MySources\kicad\build\x64-Debug\kicad
>>>> C:\MySources\kicad\qa\drc_proto\drc_engine.cpp 245
>>>> Error C2440 'type cast': cannot convert from 'wxString' to 'const char
>>>> *' C:\MySources\kicad\build\x64-Debug\kicad
>>>> C:\MySources\kicad\qa\drc_proto\drc_engine.cpp 250
>>>>
>>>>
>>>> Thanks
>>>>
>>>> Roberto
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>> More help   : https://help.launchpad.net/ListHelp
>>>>
>>>
>>>
>>> --
>>> [image: KiCad Services Corporation Logo]
>>> Seth Hillbrand
>>> *Lead Developer*
>>> +1-530-302-5483‬ <+12126039372>
>>> Davis, CA
>>> www.kipro-pcb.com    info@xxxxxxxxxxxxx
>>>
>>
>
> --
> [image: KiCad Services Corporation Logo]
> Seth Hillbrand
> *Lead Developer*
> +1-530-302-5483‬ <+12126039372>
> Davis, CA
> www.kipro-pcb.com    info@xxxxxxxxxxxxx
>