kubuntu-council team mailing list archive

[Brian Murray <brian@xxxxxxxxxx>]

Review: Needs Fixing

I've just a couple of in-line comments regarding some grammar and formatting.

Diff comments:

> diff --git a/testcases/image/1731_Netinstall (arm64 server live) b/testcases/image/1731_Netinstall (arm64 server live)
> new file mode 100644
> index 0000000..b6dcacc
> --- /dev/null
> +++ b/testcases/image/1731_Netinstall (arm64 server live)
> @@ -0,0 +1,34 @@
> +This testcase is to run netboot installation on arm64 machines. You need an installed Ubuntu machine in same network.

"in the same"

> +
> +<em>Proceed in your native language if you wish. Instructions will remain in English.</em>
> +
> +<release> is the current developing codename. <host> is the IP address of installed Ubuntu machine.

"current development codename". I also think putting a carriage return before <host> will make that easier to find when scanning the text.

> +On your installed Ubuntu machine.
> +
> +<dl>
> +    <dt>sudo apt install -y tftpd-hpa apache2</dt>
> +    <dt>sudo curl http://cdimage.ubuntu.com/ubuntu-server/daily-live/current/<release>-live-server-arm64.iso -o /var/www/html/test-live-server-arm64.iso</dt>
> +    <dt>sudo mkdir /var/lib/tftpboot/grub /var/lib/tftpboot/casper</dt>
> +    <dt>sudo mount -o loop,ro /var/www/html/test-live-server-arm64.iso /mnt</dt>
> +    <dt>sudo cp /mnt/casper/initrd /var/lib/tftpboot/casper</dt>
> +    <dt>sudo cp /mnt/casper/vmlinuz /var/lib/tftpboot/casper</dt>
> +    <dt>sudo curl http://ports.ubuntu.com/ubuntu-ports/dists/<release>/main/uefi/grub2-arm64/current/grubnetaa64.efi.signed -o /var/lib/tftpboot/grubnetaa64.efi.signed</dt>
> +    <dt>echo "menuentry \"Netboot from Ubuntu Live image\" {" | sudo tee /var/lib/tftpboot/grub/grub.cfg</dt>
> +    <dt>echo "  set gfxpayload=keep | sudo tee -a /var/lib/tftpboot/grub/grub.cfg</dt>
> +    <dt>echo "  linux /casper/vmlinuz url=http://<host>/test-live-server-arm64.iso only-ubiquity ip=dhcp ---" | sudo tee -a /var/lib/tftpboot/grub/grub.cfg</dt>
> +    <dt>echo "  initrd /casper/initrd" | sudo tee -a /var/lib/tftpboot/grub/grub.cfg</dt>
> +    <dt>echo "}" | sudo tee -a /var/lib/tftpboot/grub/grub.cfg</dt>
> +</dl>
> +
> +Reconfigure the dhcp server for grubnetaa64.efi.signed as filename and next-server as installed Ubuntu machine. e.g.
> +
> +host testbed {
> +  hardware ethernet 00:00:00:11:22:33;
> +  next-server 192.168.10.1;
> +  filename "grubnetaa64.efi.signed";
> +}
> +
> +Power on your arm64 machine and boot from ethernet. Connect to console output and you shall see grub menu. Press ENTER to load kernel and finish the installation.
> +
> +<strong>If you finish the installation, please <a href="results#add_result">submit</a> a 'passed' result.
> +    If any action fails, or produces an unexpected result, please <a href="results#add_result">submit</a> a 'failed' result and <a href="../../buginstructions">file a bug</a>. Please be sure to include the bug number when you <a href="results#add_result">submit</a> your result.</strong>


-- 
https://code.launchpad.net/~ikepanhc/ubuntu-manual-tests/+git/ubuntu-manual-tests/+merge/395678
Your team Ubuntu Testcase Admins is subscribed to branch ubuntu-manual-tests:master.