kubuntu-council team mailing list archive

[Brian Murray <mp+449743@xxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing

To make reviewing this a bit easier I generated the new test cases using `tools/test_case_gen definitions/canary_desktop_cases.xml`. (Maybe we should run that command with appropriate arguments before submitting the MP?)

Then looking at the generated test cases I have the following comments:

1761 - manual partitioning and FDE are mutually exclusive so this test case doesn't need any TPM additions
1762 - Can you resize an existing install and then do an FDE install alongside it? (I don't know!) Regardless if you can we'd want an auto-resize w/ FDE and and an auto-resize w/o FDE test case - so there should be a new test added for the latter.
1764 - This doesn't require any changes as installing with FDE after safe graphics mode wouldn't change the installed system afaik
1769 - Here we'd want a new test case that is essentially the same but with the addition of FDE
1770, 1772, 1773 - I don't think we need FDE variations of these test cases given what they are testing

Thanks!

Diff comments:

> diff --git a/definitions/canary_desktop_cases.xml b/definitions/canary_desktop_cases.xml
> index fc632c9..5c38ea7 100644
> --- a/definitions/canary_desktop_cases.xml
> +++ b/definitions/canary_desktop_cases.xml
> @@ -212,7 +212,53 @@
>        <dd>The system loads into FAMILY showing username selected</dd>
>    </ut:test>
>  
> -  <ut:case id="1760_Canary Install (entire disk)">
> +  <ut:test id="enable-full-disk-encryption-tpm">
> +    <dt>Click on "Advanced features"</dt>
> +      <dd>Click on the tickbox for "Enhanced secure-boot"</dd>
> +      <dd>Click on the tickbox for Hardware-backed full disk encryption</dd>
> +      <dd>Click "Ok"</dd>
> +    <dt>Click Continue</dt>
> +  </ut:test>
> +
> +  <ut:test id="full-disk-encryption-no-tpm-not-available">
> +    <dt>Click on "Advanced features"</dt>
> +      <dd>There should be no tickbox for "Enhanced secure-boot"</dd>

The image that I'm testing from 20230905.1 calls this "hardware-backed full disk encryption" so this needs updating.

> +      <dd>Click "Ok"</dd>
> +    <dt>Click Continue</dt>
> +  </ut:test>
> +
> +  <ut:test id="no-tpm-check">
> +    <dt>Click on "Advanced features"</dt>
> +    <dt>Verify there is no option for Hardware backed full disk encryption with TPM.</dt>

This should be "Hardware-backed" for consistency.

> +  </ut:test>
> +
> +  <ut:test id="no-tpm-reason-no-tpm">
> +    <dt>For this check, please use a system with no TPM enabled hardware</dt>
> +  </ut:test>
> +
> +  <ut:test id="no-tpm-reason-low-disk">
> +    <dt>For this check, please use a system with TPM enabled hardware, with approx 20G of disk space. The install should fail later on.</dt>
> +  </ut:test>
> +
> +  <ut:test id="no-tpm-reason-misc-template">
> +    <dt>For this check, please use a system with TPM enabled hardware, with $REASONITWILLFAIL.</dt>
> +  </ut:test>
> +
> +  <ut:test id="tpm-on-boot">
> +    <dt>After rebooting, log in to the installed system and run `snap list`, and check that the `pc-kernel` package is installed.</dt>
> +    <dt>Open up a terminal window, and try to run this command: `sudo apt install linux-image-generic`.</dt>
> +      <dd>You should get a response which includes this message: `boot-managed-by-snapd : Conflicts: linux-image`</dd>
> +  </ut:test>
> +
> +  <ut:test id="hw-requirements">
> +    <dt>In order to do full disk encryption with TPM, you either need to make sure you're using a piece of hardware that has TPM functionality, or you can install with a VM, making sure you have the correct options set to emulate a TPM backed system.</dt>
> +  </ut:test>
> +
> +  <ut:test id="should-fail">
> +    <dt>Somewhere along the installation process, either in the install screen or after reboot, the install should fail.</dt>
> +  </ut:test>
> +
> +  <ut:case id="1760_Canary Install (entire disk no tpm)">
>      <ut:include ref="grub" />
>      <ut:include ref="try-or-install" />
>      <ut:include ref="start" />


-- 
https://code.launchpad.net/~ubuntu-testcase/ubuntu-manual-tests/+git/ubuntu-manual-tests/+merge/449743
Your team Ubuntu Testcase Admins is subscribed to branch ubuntu-manual-tests:main.