kubuntu-council team mailing list archive

[Chris Peterson <mp+453468@xxxxxxxxxxxxxxxxxx>]

Thank you for the review. I addressed all of your comments and made subsequent changes. I also added a note to the top of the testcase making explicit what the instructions are asking the tester to setup, with a link to https://wiki.ubuntu.com/UEFI/SecureBoot/PXE-IPv6 for further information on setting up a PXE server. 

Going to try force-pushing the commit to keep commit history clean, but I hope this doesn't mess up the comments here...

Diff comments:

> diff --git a/testcases/image/1734_PXE UEFI Netboot (Server live) b/testcases/image/1734_PXE UEFI Netboot (Server live)
> new file mode 100644
> index 0000000..8b6d576
> --- /dev/null
> +++ b/testcases/image/1734_PXE UEFI Netboot (Server live)
> @@ -0,0 +1,63 @@
> +<p>
> +This testcase is to run netboot installation on amd64 machines with <b>UEFI</b>
> +firmware using live images. You need an installed Ubuntu machine in the same
> +network, configured with a static IP, which will be functioning as a PXE server
> +with DHCP.
> +</p>
> +
> +<em>
> +    Proceed in your native language if you wish. Instructions will remain in
> +    English.
> +</em>
> +
> +<dl>
> +    <dt>HOST is the IP address of the machine acting as the PXE/DHCP server.</dt>
> +    <dt>NETBOOT-URL is the compressed netboot artifacts archive, as listed in the
> +        download links for the test case.</dt>
> +    <dt>INTERFACE is the relevant network interface on the HOST.</dt>
> +    <dt>STARTADDR and ENDADDR are the start and end points for dhcp addresses to
> +        be handed out on this test network.  Choose appropriate values to match
> +        the static network configuration of the HOST, and see the manpage for
> +        dnsmasq for more details.</dt>
> +</dl>
> +
> +
> +<p>Install packages for the various services:</p>
> +<dl>
> +    <dt>sudo apt install -y curl dnsmasq tftpd-hpa</dt>

Good point. This is a simple change too, so fixed.

> +</dl>
> +
> +<p>Configure /etc/dnsmasq.d/pxe.conf:</p>
> +
> +<pre>
> +interface=INTERFACE,lo

Same. This is a leftover from the previous instruction's iteration. Testing these instructions was a bit of a headache for me so I left the stale instructions since these changes are incremental. I'll remove the ",lo" bit.

> +bind-interfaces
> +dhcp-range=INTERFACE,STARTADDR,ENDADDR
> +dhcp-boot=bootx64.efi

I do like the idea of unifying the architecture invariant instructions. Although until we make a single UEFI test case, I think we should just keep the single architecture in the instructions.

> +enable-tftp

Yes this seems right. Removed the installation.

> +tftp-root=/srv/tftp
> +</pre>
> +
> +<p>Restart dnsmasq:</p>
> +
> +<dl>
> +    <dt>sudo systemctl restart dnsmasq.service</dt>
> +</dl>
> +
> +<p>Download the netboot artifacts:</p>
> +<dl>

Thanks, changed to <ul> and <ol> in similar spots. The isotracker website seems to convert <dt> to numbered list so I had left it.

> +    <dt>sudo curl NETBOOT-URL -o /tmp/netboot-artifacts.tar.gz</dt>

changed to wget instead

> +    <dt>sudo tar -zxvf /tmp/netboot-artifacts.tar.gz --strip-components=2 -C /srv/tftp/</dt>

Agreed. I didn't really like the --strip-components bit anyways. Changed.

> +</dl>
> +
> +
> +
> +<p>
> +Power on the test machine and ensure that it boots PXE. Complete the installation

Suggestion committed.

> +(using the provided defaults where possible) and remove the device from the network once it's finished. Reboot the machine

Makes sense, local UEFI/BIOS boot should be higher priority than PXE boot I'd think. I removed this instruction.

> +and ensure that you can log into the system with the username and password you
> +provided.
> +</p>
> +
> +<strong>If you finish the installation, please <a href="results#add_result">submit</a> a 'passed' result.
> +    If any action fails, or produces an unexpected result, please <a href="results#add_result">submit</a> a 'failed' result and <a href="../../buginstructions">file a bug</a>. Please be sure to include the bug number when you <a href="results#add_result">submit</a> your result.</strong>


-- 
https://code.launchpad.net/~cpete/ubuntu-manual-tests/+git/ubuntu-manual-tests/+merge/453468
Your team Ubuntu Testcase Admins is subscribed to branch ubuntu-manual-tests:main.