launchpad-dev team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

On Mon, 2009-08-10 at 12:04 +0100, Julian Edwards wrote:
> Hi guys
> 
> Thanks for doing this change William, and thanks for sponsoring him Celso.
> 
> > === added file 'lib/lp/soyuz/stories/webservice/xx-archivedependency.txt'
> > --- lib/lp/soyuz/stories/webservice/xx-archivedependency.txt    1970-01-01
> > 00:00:00 +0000 +++ lib/lp/soyuz/stories/webservice/xx-archivedependency.txt
> >    2009-08-07 23:30:05 +0000 @@ -0,0 +1,114 @@
> > += Archive dependencies =
> > +
> > +`ArchiveDependency` records represent build-dependencies between
> > +archives, and are exposed through the API.
> > +
> > +Most of the tests live in
> > +lib/lp/soyuz/stories/webservice/xx-archive.txt.
> 
> Why not put all those tests in this new file?  I found it confusing to see 
> them in two places.
> 
> Ideally I'd like to split up xx-archive.txt more anyway, it's way too big!  We 
> could at least have xx-archive-permissions.txt, xx-archive-copying.txt and xx-
> archive-subscriptions.txt !

It's because it's so big that it got bigger. I followed the example of
the existing types of tests that you mention there, and added the new
ones underneath. It should be split up, you're right.

-- 
William Grant