launchpad-dev team mailing list archive

[Jonathan Lange <jml@xxxxxxxxxxxxx>]

This is _really_ late, I'm afraid. I went on leave after the sprint
and have only just found this file. It's still worth sending out, even
if the only reply I get is "Yeah, we know, we've fixed that already."

----

At the platform sprint, I got some real-time feedback from the distro
folks about the code review system.

Here's how it goes:

 * They'd like a way to say, "I have responded to your review, please
look at my response".

 * It sucks that you lose the _flow_ of conversation when you resubmit
a merge proposal. They know the old conversation is still there, but
it's hidden, and really it's the same conversation as takes place with
the new diff.

 * The invited reviewers are lost when resubmitting merge proposals.

 * Marking as "superseded" mails out the URL for the old branch location

 * We really need a spinner / throbber that's going while we're
waiting for the diff to load.

 * We should have an interdiff on resubmitted merge proposals

 * How feasible is it to have special diffing for package branches?
Distro folk are mostly interested only in the diff of the debian/
directory, not in changes to the main code.

I've not been following closely while on leave, but I think that some
of these might have been addressed already.

Thoughts?
jml