← Back to team overview

launchpad-dev team mailing list archive

Re: [Branch ~launchpad-pqm/launchpad/devel] Rev 9596: [r=barry][ui=rs][bug=114710] It is now always possible to comment on

 

On Mon, 5 Oct 2009 10:52:36 -0300
Christian Robottom Reis <kiko@xxxxxxxxxxxxx> wrote:

> On Sun, Oct 04, 2009 at 10:15:59AM +0100, Gavin Panella wrote:
> > On Sat, 3 Oct 2009 16:50:12 -0300
> > Christian Robottom Reis <kiko@xxxxxxxxxxxxx> wrote:
> > 
> > > Hey, could the button label say "Just add a comment" and be the third
> > > option? What do you think, Martin?
> > 
> > This branch moved the comment button to the rightmost position (see
> > question-index.pt), which for us, doing CHR for example, means it will
> > appear as the third option. Is that what you want, or do you want it
> > to appear strictly at the third position?
> 
> I didn't quite understand your question but I think we were agreeing; it
> should look like this:
> 
>   Answer this question    Request more information   Just make a comment
> 
> Right?

Yeah. I was splitting hairs to some extent. It's a fiddly question
that probably doesn't make much sense unless you've recently looked at
QuestionWorkflowView and question-index.pt.

There are six buttons that can appear underneath the comment
box. Different combinations are shown according to the question
state. I don't think there's ever a situation where all buttons appear
at the same time though.

Most of the time a person trying to answer questions (e.g. CHR) will
see the three buttons appear as you describe above. However, I moved
the comment button to the rightmost of *all 6* buttons. These are now,
in order:

  Add Answer
  Problem Solved
  Add Information Request
  I'm Providing More Information
  I Still Need an Answer
  Add Comment

I wondered if you always wanted "Add Comment" to appear after all the
others, whatever buttons are displayed, or if you wanted it to appear
after "Add Answer" and "Add Information Request", but before "I'm
Providing More Information" and "I Still Need an Answer".

It's a minor enough point that I probably should have kept my mouth
shut in the first place :)

Gavin.



Follow ups

References