launchpad-dev team mailing list archive

[Jonathan Lange <jml@xxxxxxxxxxxxx>]

On Thu, Dec 3, 2009 at 6:24 PM, Michael Hudson
<michael.hudson@xxxxxxxxxxxxx> wrote:
> Julian Edwards wrote:
>> Right, I just had a good call with Jono and we've cleared a bunch of stuff up
>> between us.
>
> Excellent.
>
>> The upshot is that you need a few more changes to the schema:
>>
>>  1. SourcePackageRecipeData needs a "type" column so we know if it's a
>> manifest or a recipe.  This will help with indexing, especially since we'll
>> have loads more manifests than recipes.
>
> I'm not sure I see why, but OK.
>

One reason would be to enforce a constraint such that manifest rows
always have associated revisions.

>>  2. SourcePackageRecipeDataBranch needs a revision number.  This is more
>> pertinent to manifests but Jono tells me it should be used for recipes too.
>
> Um, revision *number*?  I would have thought a text revspec or revision
> id field would make more sense.
>
> I'd like to talk about this bit some more I guess.
>

I think Julian meant "foreign key referring to the Revision table".

The reason is that:
  a) Manifests need it
  b) Recipes might refer to it

>>  3. SourcePackageBuildUpload should have a requester column
>
> Cool, I'd already come around to this point of view.
>

Hurrah for merry agreement.

jml