launchpad-dev team mailing list archive

[Julian Edwards <julian.edwards@xxxxxxxxxxxxx>]

On Thursday 03 December 2009 18:24:05 Michael Hudson wrote:
> I meant 'SPBuild will never have this particular value from BuildState
> that indicates an upload has happened in its buildstate column', it's
> clear that SPBuild needs a buildstate column.

Right, it doesn't really matter that we have states unused in some build 
types.

> Though now I look at the code, I don't really understand how the
> uploaded-ness is tracked through buildstate.

When the build is finished it either goes to FULLYBUILT or FAILEDTOUPLOAD 
depending on the outcome of the upload.

> 
> > In fact the existing lp.soyuz.interfaces.build.BuildStatus will continue
> > to apply for all build job types.  We need to move that enum somewhere
> > else now though.
> 
> lp.soyuz.enums!  Worked well for code, that idea.

Yeah I like that a lot.

Cheers.