launchpad-dev team mailing list archive

[Barry Warsaw <barry@xxxxxxxxxxxxx>]

I'm trying to land my branch fixing bug 409588, but decided to run the full
test suite first.  I had five failures, three of which are legitimate and easy
to fix.  I'm seeing two others though that are also in devel, so I think they
are spurious.  I don't have time to look into the details, so I thought I'd at
least let y'all know about them.

I'm landing my branch anyway.

-Barry

-----snip snip-----
% bin/test -vv -t test_lpserve
Running tests at level 1
Running zope.testing.testrunner.layer.UnitTests tests:
  Set up zope.testing.testrunner.layer.UnitTests in 0.000 seconds.
  Running:
 test_successful_start_then_stop (lp.codehosting.tests.test_lpserve.TestLaunchpadServe)

Failure in test test_successful_start_then_stop (lp.codehosting.tests.test_lpserve.TestLaunchpadServe)
Traceback (most recent call last):
  File "/home/barry/projects/launchpad/eggs/bzr-2.1.0b3-py2.5-linux-x86_64.egg/bzrlib/tests/__init__.py", line 1653, in _run
    testMethod()
  File "/home/barry/projects/launchpad/409588-mlists/lib/lp/codehosting/tests/test_lpserve.py", line 168, in test_successful_start_then_stop
    self.assertFinishedCleanly(result)
  File "/home/barry/projects/launchpad/409588-mlists/lib/lp/codehosting/tests/test_lpserve.py", line 62, in assertFinishedCleanly
    result[2]))
  File "/usr/lib/python2.5/unittest.py", line 309, in failUnless
    if not expr: raise self.failureException, msg
AssertionError


 test_successful_start_then_stop_logs_no_oops (lp.codehosting.tests.test_lpserve.TestLaunchpadServe)
 test_unexpected_error_logs_oops (lp.codehosting.tests.test_lpserve.TestLaunchpadServe)

Failure in test test_unexpected_error_logs_oops (lp.codehosting.tests.test_lpserve.TestLaunchpadServe)
Traceback (most recent call last):
  File "/home/barry/projects/launchpad/eggs/bzr-2.1.0b3-py2.5-linux-x86_64.egg/bzrlib/tests/__init__.py", line 1653, in _run
    testMethod()
  File "/home/barry/projects/launchpad/409588-mlists/lib/lp/codehosting/tests/test_lpserve.py", line 190, in test_unexpected_error_logs_oops
    self.assertFinishedCleanly(result)
  File "/home/barry/projects/launchpad/409588-mlists/lib/lp/codehosting/tests/test_lpserve.py", line 62, in assertFinishedCleanly
    result[2]))
  File "/usr/lib/python2.5/unittest.py", line 309, in failUnless
    if not expr: raise self.failureException, msg
AssertionError


  Ran 3 tests with 2 failures and 0 errors in 4.586 seconds.
Tearing down left over layers:
  Tear down zope.testing.testrunner.layer.UnitTests in 0.000 seconds.

Tests with failures:
   test_successful_start_then_stop (lp.codehosting.tests.test_lpserve.TestLaunchpadServe)
   test_unexpected_error_logs_oops (lp.codehosting.tests.test_lpserve.TestLaunchpadServe)

** 2 import policy violations **

There were 2 imports of names not appearing in the __all__.
You should not import domain_match from cookielib:
    canonical.launchpad.webapp.session
You should not import mktime_tz from email.Utils:
    canonical.launchpad.database.message

Attachment: signature.asc
Description: PGP signature