launchpad-dev team mailing list archive

[James Westby <jw+debian@xxxxxxxxxxxxxxx>]

On Tue, 23 Mar 2010 19:20:08 -0400, James Westby <jw+debian@xxxxxxxxxxxxxxx> wrote:
> Hi,
> 
> I'm seeing a test failure in webservice-marshallers.txt:
> 
> File "lib/canonical/launchpad/ftests/../doc/webservice-marshallers.txt",
> line 86, in webservice-marshallers.txt
> Failed example:
>     request.publication.endRequest(request, None)
> Exception raised:
>     Traceback (most recent call last):
>       File
>       "/home/jw2328/devel/lp-sourcedeps/eggs/zope.testing-3.8.1-py2.5.egg/zope/testing/doctest.py",
>       line 1361, in __run
>         compileflags, 1) in test.globs
>       File "<doctest webservice-marshallers.txt[line 86, example 31]>",
>       line 1, in <module>
>       File
>       "/home/jw2328/devel/launchpad/devel/lib/canonical/launchpad/webapp/publication.py",
>       line 634, in endRequest
>         self.endProfilingHook(request)
>       File
>       "/home/jw2328/devel/launchpad/devel/lib/canonical/launchpad/webapp/publication.py",
>       line 706, in endProfilingHook
>         now = datetime.fromtimestamp(da.get_request_start_time())
>     TypeError: a float is required
> 
> Michael confirms that he sees it in devel, db-devel and
> production-devel.

I'm also seeing this same failure testing lp:launchpad/devel on ec2.

I looked at it more, and it's a test isolation issue: when run without
the preceeding tests it fails. So, running

  ./bin/test -t lib/canonical/launchpad/ftests/../doc/webservice

succeeds, but

  ./bin/test -t lib/canonical/launchpad/ftests/../doc/webservice-marshallers

fails, implying that 

  lib/canonical/launchpad/doc/webservice-error.txt

isn't correctly isolated. So...

  https://code.edge.launchpad.net/~james-w/launchpad/fix-webservice-test-isolation/+merge/22040

Thanks,

James