← Back to team overview

launchpad-dev team mailing list archive

Re: PPA key generation is currently broken

 

On 04/05/10 23:28, Julian Edwards wrote:
I think this might be related to the pygpgme change that was done recently,
but can anyone take a guess at why the script is bailing out with this?

2010-05-04 22:00:41 INFO    Generating signing key for PPA for Kristian Klette
2010-05-04 22:02:32 DEBUG   Removing lock file: /var/lock/launchpad-ppa-
generate-keys.lock
Traceback (most recent call last):
   File "/srv/launchpad.net/codelines/current/cronscripts/ppa-generate-
keys.py", line 21, in<module>
     script.lock_and_run()
   File "/srv/launchpad.net/codelines/ppa-
rev-9329/lib/lp/services/scripts/base.py", line 280, in lock_and_run
     implicit_begin=implicit_begin, isolation=isolation)
   File "/srv/launchpad.net/codelines/ppa-
rev-9329/lib/lp/services/scripts/base.py", line 238, in run
     self.main()
   File "/srv/launchpad.net/codelines/ppa-
rev-9329/lib/lp/soyuz/scripts/ppakeygenerator.py", line 62, in main
     self.generateKey(archive)
   File "/srv/launchpad.net/codelines/ppa-
rev-9329/lib/lp/soyuz/scripts/ppakeygenerator.py", line 33, in generateKey
     archive_signing_key.generateSigningKey()
   File "/srv/launchpad.net/codelines/ppa-
rev-9329/lib/lp/archivepublisher/archivesigningkey.py", line 75, in
generateSigningKey
     secret_key = getUtility(IGPGHandler).generateKey(key_displayname)
   File "/srv/launchpad.net/codelines/ppa-
rev-9329/lib/canonical/launchpad/utilities/gpghandler.py", line 307, in
generateKey
     secret_keys = list(self.localKeys(result.fpr, secret=True))
   File "/srv/launchpad.net/codelines/ppa-
rev-9329/lib/canonical/launchpad/utilities/gpghandler.py", line 402, in
localKeys
     for key in ctx.keylist(filter, secret):
TypeError: first argument must be a string or sequence of strings


The new pygpgme's result.fpr is now a unicode object, but apparently the filter argument to keylist is still wanted as a bytestring.

Max.



References