launchpad-dev team mailing list archive

[Stuart Bishop <stuart.bishop@xxxxxxxxxxxxx>]

On Tue, May 11, 2010 at 1:51 AM, Maris Fogels
<maris.fogels@xxxxxxxxxxxxx> wrote:

> Thanks Andrew.  Sounds good to me :)
>
> So, a follow-up question then: would it be too much work to add such
> checking to the Launchpad test suite?

We already do similar sanity checks in the test layers.

You put the check in BaseLayer.testTearDown. If there are any OOPS
reports, call BaseLayer.flagTestIsolationFailure. Search for
BaseLayer.disable_thread_check for something similar. I'd set it so
tests that leave OOPS reports around will fail, and provide a simple
API for tests to clean up OOPS reports (probably on BaseLayer).


-- 
Stuart Bishop <stuart@xxxxxxxxxxxxxxxx>
http://www.stuartbishop.net/