launchpad-dev team mailing list archive

[Jonathan Lange <jml@xxxxxxxxxxxxx>]

On Mon, Jul 26, 2010 at 1:05 AM, Jeroen Vermeulen <jtv@xxxxxxxxxxxxx> wrote:
> Hi folks,
>
> I've been discussing this with a few of you: a fake Librarian.
>
> https://code.launchpad.net/~jtv/launchpad/fake-librarian/+merge/30907
>
> I'd very much appreciate your opinions on this.  Is it worth doing?  Can it
> work?  Should it be done better?  I was thinking perhaps we could rip the
> Librarian out of the LaunchpadLayer eventually and move the tests that it
> won't work with into a new layer.

I think it's worth doing.

I'm very glad you've got unit tests for this code, but I think it
would be better still if we tested the fake librarian and the real
librarian with the same set of tests. That way we can be confident
that our fake isn't masking bugs.[1]

What does moving the Librarian out of the LaunhpadLayer into a new layer win?

jml

[1] And of course, every time we discover it *is* masking bugs, we add
more tests that run against both real and fake.