launchpad-dev team mailing list archive

[James Westby <james.westby@xxxxxxxxxxxxx>]

On Thu, 05 Aug 2010 10:38:53 -0400, Aaron Bentley <aaron@xxxxxxxxxxxxx> wrote:
> On 08/05/2010 10:30 AM, Julian Edwards wrote:
> > On Thursday 05 August 2010 15:06:35 James Westby wrote:
> >> There is also SourcePackageRecipeBuild that I missed before. This is
> >> CASCADE on Archive, but there are several references to it that need to
> >> be taken care of.
> >>
> >>   - SourcePackageRecipeBuildUpload - CASCADE?

> Not familiar to me.  May not actually be used outside of
> archiveuploader/tests/test_recipeuploads.py

Yeah, I'm having trouble finding reference to it.

> >>   - SPR - already NULLable, so again it's just that we could have an
> >>        SPR that we don't know the origin of any more.
> >>   - SourcePackageRecipeBuildJob - prevent deletion?

> I would probably warn, the way we do on branch deletion, and then delete
> if the user decided to proceed.

I assumed this was parallel to PackageBuild that Julian was saying
should prevent deletion. Can we go ahead and just delete
SourcePackageRecipeBuildJob?

> >>   - SourcePackageRecipeData - CASCADE
> > 
> > I'm not as familiar with that data model.  Aaron?
> >>   * SourcePackageRecipe.daily_build_archive - already NULLable. Again a
> >>      warning here would be appropriate when deleting.
> > 
> > Aaron would have to comment there.

> I would NULL the field, but that's conservative.  It's quite likely the
> user has no use for the recipe if they're deleting the archive that was
> its target.

My instinct would be to be conservative as well.

Thanks,

James