launchpad-dev team mailing list archive
-
launchpad-dev team
-
Mailing list archive
-
Message #04220
Re: optimizing adding team members
On Wed, 11 Aug 2010 10:20:36 +1200, Robert Collins <robert.collins@xxxxxxxxxxxxx> wrote:
> On Wed, Aug 11, 2010 at 10:08 AM, Edwin Grubbs
> <edwin.grubbs@xxxxxxxxxxxxx> wrote:
> > After looking at bugs 353950 and 615654 and their oopses, it appears
> > that the two main causes of the timeouts are
> > TeamMembership._fillTeamParticipation() and
> > TeamMembership._sendStatusChangeNotification(), which sends emails to
> > all the members of a team individually if it does not have a preferred
> > email address.
>
> So, in general - neither of these things is directly what the user
> asked us to do - they are respectively housekeeping a cache and
> performing notifications about the change.
TeamParticipation is not a cache. It may be an unncessary
pre-calculation (although I doubt it), but it's how all questions of
team membership are answered.
Cheers,
mwh
Follow ups
References