← Back to team overview

launchpad-dev team mailing list archive

Re: Forking 'bzr lp-serve'

 

On Tue, Sep 14, 2010 at 9:31 PM, Robert Collins
<robertc@xxxxxxxxxxxxxxxxx> wrote:
> On Wed, Sep 15, 2010 at 8:26 AM, John Arbash Meinel
> <john@xxxxxxxxxxxxxxxxx> wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> So I've finally gotten the end-to-end code working, such that 'ssh lp
>> bzr serve ...' can actually use a daemon which preloads some python
>> libraries, forks for each request, and doesn't re-exec.
>>
>>  lp:~jameinel/launchpad/lp-service
>>
>>
>> I think there is still a fair number of cleanup passes necessary, but I
>> think for all of that I'm going to need a bit of help. Stuff like "where
>> should I be putting the log files", etc.
>>
>> As such, what is the best way to progress forward? Put it up as a merge
>> request? Get someone to pair with me for a little while to have a quick
>> turn around for all those little questions?
>
> I suggest:
>  - get it reviewed and then either:
>  - guard it with a featureflag so its inactive, and land it disabled
> to be iterated on
>  - keep tuning it until everything seems honky dory and then land
> with shock and awe.
>

I agree with Rob's general plan.

Also, I may be able to help with specific questions about the
codehosting service.

Thanks for doing this!
jml



References