launchpad-dev team mailing list archive

[Michael Hudson <michael.hudson@xxxxxxxxxxxxx>]

On Mon, 18 Oct 2010 00:00:35 +1300, Robert Collins <robertc@xxxxxxxxxxxxxxxxx> wrote:
> So I've read through the code, and AFAICT this is all thats needed:
>  - a unique ftesting.zcml per parallel runner,
>  - with a unique +config-overrides.zcml file included
>  - with a unique config name
>  - which inherits from testrunner on disk.

You may know this already, but the inheritance here only works with the
lazr.config portion, not the launchpad.conf files or any zcml.  I guess
we need to just copy those when creating the config on the fly.

>  - and has a matching appserver config which inherits from testrunner-appserver
>
> And then per-thing-that-needs-to-be-unique (e.g. dbname), we write
> that out into the unique config.
> 
> Am I missing some stuff?

Well, you need a way to make each test run load a different
ftesting.zcml.  I've no idea how hard or trivial that is.  But the rest
sounds about right.

> Some context - we need to allocate unique ports, dbnames, etc for
> testing with, and while I'd like to do stuff really cleanly, I also
> want it working now :) - so I'm looking for the highest-leverage point
> to push on in the short term - whilst this might seem ugly, it seems
> like it should let us have the existing test code and config code
> manage to work.

+1 to working.

> it would be nice if I knew why we had the -appserver variation though,
> I don't understand why its necessary or beneficial.

I have no idea.  It may predate the lazr.config transition, which made
our lives much easier in this sort of area.  Ask Barry?  It was he who
implemented support for appserver tests.

Cheers,
mwh