launchpad-dev team mailing list archive

[Ian Booth <ian.m.booth@xxxxxxxxx>]

> 
> Remaining things to do:
>  - the readonly flag tests
>  - librarian
>  - something is dropping launchpad_ftest_template
>  - memcache
>  - appserver http ports (wallyworld reports that this has /100's/ of
> tests to update
> 

With the http ports, I misspoke a little - the number of actual tests is
less than 100 but there were over 100 places that needed changing. Sorry
for any confusion. The main tests affected were the windmill tests, yui
tests, a bunch of doc tests and some unit tests.

I've just finished making the necessary changes and all the tests I've
thrown at it pass. Essentially, instead of a hard coded url port of 8085
being assumed, the port is accessed via the current config instance and
is no longer a fixed value. So, for example,  stuff like:

browser.open('http://launchpad.dev:8085/~stimpy')

is verboten. Instead, there's an api to get the root url to use, eg:

root_url = getRootLaunchpadUrl()
browser.open('%s/~stimpy' % root_url)

I'll send out a more detailed email once my branch lands. I just want to
get sign off on the final api for determining the root urls and I also
need to feed off lifeless's uniqueconfig branch in order to pick up the
config name to use behind the scenes.

The bottom line is:

1. All existing tests have been migrated already - I just finished doing
it :-)
2. There'll be a few simple patterns people will need to use in order to
no longer depend on the hard coded 8085 port number. The pattern to use
depends on the type of test: doc, windmill, unit etc. In all cases, any
required change is trivial like the above example.

One TODO is the launchpadlib codebase - the tests there need porting but
I figure those can wait a little to this current stuff gets done.

I also just want to thank lifeless for getting this initiative off the
ground. I for one can't wait for it all to come to fruition.