launchpad-dev team mailing list archive

[Paul Hummer <paul.hummer@xxxxxxxxxxxxx>]

On Tue, 26 Oct 2010 12:55:31 -0400
Aaron Bentley <aaron@xxxxxxxxxxxxx> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 10/26/2010 12:19 PM, Paul Hummer wrote:
> > On Tue, 26 Oct 2010 16:52:24 +0100
> > Gavin Panella <gavin.panella@xxxxxxxxxxxxx> wrote:
> >>   https://code.edge.launchpad.net/~allenap/launchpad/remove-with-statement/+merge/39381
> > 
> > This is a perfect example of a branch that doesn't need a review.
> 
> Is it?  What if I'd submitted such a branch last week?

Well, Gavin didn't send it without context.  I knew what it was doing,
and why.  In that case, I don't need to look at it.  It's a rubber
stamp.  But if such a branch were submitted last week and I had been
given the same context, my red flag is already being set off before I
look at any code.

Cheers,
Paul