launchpad-dev team mailing list archive

[Michael Hudson <michael.hudson@xxxxxxxxxxxxx>]

On Mon, 8 Nov 2010 13:51:26 +0000, Jonathan Lange <jml@xxxxxxxxxxxxx> wrote:
> On Mon, Oct 18, 2010 at 5:49 AM, Robert Collins
> <robertc@xxxxxxxxxxxxxxxxx> wrote:
> > On Mon, Oct 18, 2010 at 5:20 PM, Tim Penhey <tim.penhey@xxxxxxxxxxxxx> wrote:
> >> On Mon, 18 Oct 2010 17:07:53 Robert Collins wrote:
> >>> Wondering if anyone has ideas about this - the branch is trivial -
> >>> grab a new testtools, use it. Drop things that are now in testtools
> >>> core.
> >>>
> >>> And yet, it fails.
> >>
> >> And if you look at the failures, they are in testtools matchers.
> >
> > yes, but I don't see /why/ they'd trigger this.
> 
> Did you ever get to the bottom of this? Inquiring minds want to know.

Yes, it was that a new version of testtools ended up comparing things
the other way around in assertEquals, and we had some broken tests that
compared storm expressions and dates (UTC_NOW == anything is true,
anything == UTC_NOW is not, at least for most values of anything).

I'm pretty sure the fixes to the tests landed.

Cheers,
mwh