launchpad-dev team mailing list archive

[Aaron Bentley <aaron@xxxxxxxxxxxxx>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/19/2010 06:06 PM, Curtis Hovey wrote:
> === modified file 'lib/lp/registry/interfaces/person.py'
> --- lib/lp/registry/interfaces/person.py	2010-11-18 12:05:34 +0000
> +++ lib/lp/registry/interfaces/person.py	2010-11-19 22:31:16 +0000
> @@ -1551,6 +1551,11 @@
>          to INVITATION_DECLINED.
>          """
>  
> +    @call_with(user=REQUEST_USER)
> +    @operation_parameters(
> +        team=copy_field(ITeamMembership['team']),
> +        comment=Text(required=False))
> +    @export_write_operation()
>      def retractTeamMembership(team, user, comment=None):
>          """Retract this team's membership in the given team.
> 
> This small change causes a long TB. I suspect I need to define methods
> in a 1.0 or beta API, but I do not know how to version an interface. I
> even more puzzled in that the death is an interface I have not changed:
>     forSchemaInterface(lp.soyuz.interfaces.archive.IArchive, self.request)
> ^ this method used in two places in Lp code, and they have nothing to do
> with archive.


It looks like the problem is that ITeamMemberShip.team is patched on
line 2065, but you're copying it on an earlier line, so you're copying
the unpatched version.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkzqgMoACgkQ0F+nu1YWqI2/6gCfdmO9Lb60WxisAU6x/yMMKGY0
LqwAn0RvGHUi/CaW/5slrjRiS4JlDXRS
=9lQF
-----END PGP SIGNATURE-----