launchpad-dev team mailing list archive

[Brad Crittenden <brad.crittenden@xxxxxxxxxxxxx>]

> Thanks, but I'm looking for a guideline I can use as a reviewer to say
> "your tests are taking too long" or "your tests are astoundingly fast--
> please share your secrets with the mailing list".  Without numbers, I
> can't do that.

Hi Aaron,

Reviews are a discussion not simply enforcement of rules.  I'd have no problem saying "Wow, your new test provides great coverage but seems to be really slow.  Let's see if we can speed it up."

--Brad

> 
> Robert's metric had numbers, so it was at least theoretically possible
> to use that way.