← Back to team overview

launchpad-dev team mailing list archive

Re: QuietFakeLogger is dead, long live BufferLogger

 

On Mon, Dec 20, 2010 at 4:28 AM, Tim Penhey <tim.penhey@xxxxxxxxxxxxx> wrote:
> Hi All,
>
> After messing around with some loggers in tests I thought now was a good time
> to unify.
>
...
> QuietFakeLogger and BufferLogger were almost identical, so I have deleted
> QuietFakeLogger and renamed all uses to use BufferLogger.
>
> I have also moved the loggers to lp.services.log.logger.
>
...
> The MockLogger is also being removed in this branch.  All *FOUR* of them.
>
> FakeLogger writes to stdout, and I have a mind to rename this and change the
> base class.
>
> BufferLogger records the content in a StringIO object.
>
> DevNullLogger discards all log messages.
>

Thanks so much for doing this.  It's really great to see.

jml



References