launchpad-dev team mailing list archive

[John Arbash Meinel <john@xxxxxxxxxxxxxxxxx>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/29/2011 05:28 AM, Andrew Bennetts wrote:
> Andrew Bennetts wrote:
> [...]
>> At a glance it wouldn't be too outrageously messy to make those changes
>> to lib/lp/codehosting/vfs/transport.py, so I'll give it a go and propose
>> a patch to lp too.  Aside from having traceback-less Failures it should
>> have no change to semantics.
> 
> You can find a patch (untested, sorry!) that does this in
> <lp:~spiv/launchpad/codehosting-cheaper-failures>.  I don't think it'll avoid
> the expensive cleanFailures entirely, but hopefully will get 90% of them.  It's
> not too large:
> 
>  codehosting/vfs/branchfs.py         |   33 +++++++++++++++++++++------------
>  codehosting/vfs/branchfsclient.py   |    3 ++-
>  codehosting/vfs/transport.py        |   20 ++++++++++++++++----
>  services/twistedsupport/__init__.py |   25 ++++++++++++++++++++++---
>  4 files changed, 61 insertions(+), 20 deletions(-)
> 
> John, could you give this a try and see if it helps?
> 
> -Andrew.
> 

Best case time, 350ms. Apparently those aren't the expensive exceptions.
So it does help (350ms is better than 480ms.) But not as much as
'tb=None' ~180ms.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk2RadEACgkQJdeBCYSNAAMYigCgn0ufe3ySfLcD506lzRHYGxwj
dM8AnRNuhpxR3DI+DwdA3Sw52VaZ4eZf
=q8Pf
-----END PGP SIGNATURE-----