launchpad-dev team mailing list archive

[Curtis Hovey <curtis.hovey@xxxxxxxxxxxxx>]

On Thu, 2011-06-02 at 18:36 +0000, noreply@xxxxxxxxxxxxx wrote:
> Merge authors:
>   Henning Eggers (henninge)
> ------------------------------------------------------------
> revno: 13152 [merge]
> committer: Launchpad Patch Queue Manager <launchpad@xxxxxxxxxxxxxxxxx>
> branch nick: devel
> timestamp: Wed 2011-06-01 19:43:31 +0000
> message:
>   [r=gmb][bug=778129] Removed batch limit from InlineEditPickerWidget
>         if no search box is available.
> modified:
>   lib/lp/app/javascript/picker.js
>   lib/lp/app/javascript/tests/test_picker.js 

The lint fixes in this branch were untested, and broke yuitests.
jslint, (AKA pocketlint) correctly reported that "temp_spinner != null"
is wrong.
the fix was not "temp_spinner !== null" however, because the
temp_spinner can be undefined. I saw this issue about the same time
Henning did, but I also saw the picker was not show results anymore
after making the suggested fix. Thus lint was correct to point out that
the code was ambiguous. The code work by accident rather than by design.

This is fixed in a branch I have in ec2.

-- 
__Curtis C. Hovey_________
http://launchpad.net/

Attachment: signature.asc
Description: This is a digitally signed message part