launchpad-dev team mailing list archive

[John Arbash Meinel <john@xxxxxxxxxxxxxxxxx>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/25/2011 02:48 PM, William Grant wrote:
> Hi all,
> 
> You may see issues with test_versioninfo failing on ec2. This is
> spurious, and caused by the bzr 2.4 that crept into the image when it
> was updated yesterday. If you have a branch fail with it, please lp-land.
> 
> See https://bugs.launchpad.net/launchpad/+bug/833743 for details. The
> fix is probably trivial, and it's rather urgent. Any takers?
> 
> Thanks,
> William
> 

To clarify, this is a bug in the lp test suite, because it was building
a file with the system bzr which got upgraded in the image. The rest of
the Launchpad suite is still locked to bzr-2.3 (IIRC).

The simple fix would probably be:

- - self.assertEquals(revno, int(output))
+ self.assertEquals(int(revno), int(output))

That way it remains compatible with both bzr-2.3 and bzr-2.4.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk5WSOAACgkQJdeBCYSNAANgOgCgzmGeKGjDKDxVZ6NP1qcff5hs
ku4AoLEVwsUwEj3Utppq6HiDYJ2hDKfX
=Q8R3
-----END PGP SIGNATURE-----