launchpad-dev team mailing list archive

[Andrea Corbellini <corbellini.andrea@xxxxxxxxx>]

Hello,

This seems to me a nice feature, nice work! I have however found some
problems with it and I'd like to share my thoughts with you.

1. The comments that are shown via AJAX contain a "Hide comment" button
that seems to have no visible effect.

2. The "Hide comment" button is only visible for the comments which were
loaded via AJAX, it is not possible to hide other comments (i.e. the
ones that were shown by default).

3. The pencil icon near "Hide comment" makes me think that Launchpad
will remember my choice to hide the comment, although I doubt it will
do. If I'm not the only one who has noticed this, I think that the icon
should be changed.

4. The last problem I found is that ?comments=all is not appended to the
URL. When designing web services, I always say that one URL must
correspond to one - and exactly one - view. This makes it possible to
have permalinks for every resource/set of resources. With HTML5 it is
possible to modify the URL via Javascript without reloading the page
[1], and it shouldn't be difficult to implement this.

Thanks and good day!


[1] window.history.pushState() or replaceState(), see also
https://developer.mozilla.org/en/DOM/Manipulating_the_browser_history

On Tue, 2011-10-04 at 14:57 +0100, Graham Binns wrote:
> On 4 October 2011 14:13, Martin Albisetti <argentina@xxxxxxxxx> wrote:
> > Yay!
> > Also, it doesn't seem to work for me  :)
> > I visited: https://bugs.launchpad.net/ubuntu/+bug/1
> > And I get 80 comments loaded with the page, and when clicking on the
> > link to see all comments, I get sent to /all
> >
> > Is there something I'm missing!
> 
> Turns out there's something *we* missed. Actually, two things: the
> feature flag wasn't set for launchpad-beta-testers - now fixed - and
> the bottom link on the page doesn't get JS-ified (I'm filing a bug
> about this now). The link that _does_ get js-ified is the one in the
> middle of the comments - search for "hidden" on the page and you
> should find it easily enough.
> 
> Thanks for the feedback!

-- 
Andrea Corbellini
Ubuntu Member | http://www.ubuntu.com/

Attachment: signature.asc
Description: This is a digitally signed message part