launchpad-dev team mailing list archive

["Francis J. Lacoste" <francis.lacoste@xxxxxxxxxxxxx>]

My guess is that they are used to work-around some constraints check.

I say if you remove them and the tests pass, leave them out :-)

Cheers

On 12-03-19 06:53 PM, Guilherme Salgado wrote:
> Hi,
> 
> While discussing
> https://code.launchpad.net/~linaro-infrastructure/launchpad/notify-workitems-changes/+merge/98231
> we found that the block_implicit_flushes() decorator in an event
> subscriber was causing us some problems so Robert suggested I find out
> why it's there. The revision log of when it was introduced [1] doesn't
> say why it is needed, so I'm hoping somebody here will know...
> 
> [1]
> salgado@delgadito:~/launchpad/lp-branches/devel/lib/lp$ bzr log -r
> revid:james.henstridge@xxxxxxxxxxxxx-20080407101536-oxuijfpf7aroukea
>   5821.2.27 James Henstridge	2008-04-07
>             * Add block_implicit_flushes decorator that blocks flushes
> performed
>               implicitly by Storm methods like get(), find() and execute().
>             * Block flushes in various event handlers and in the
> security policy.
>             * A few more changes to fix particular test failures.
> 
> 
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~launchpad-dev
> Post to     : launchpad-dev@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~launchpad-dev
> More help   : https://help.launchpad.net/ListHelp


-- 
Francis J. Lacoste
francis.lacoste@xxxxxxxxxxxxx

Attachment: signature.asc
Description: OpenPGP digital signature