← Back to team overview

launchpad-dev team mailing list archive

Re: Removing IArchive.commercial

 

On Wed, May 2, 2012 at 11:36 AM, Julian Edwards
<julian.edwards@xxxxxxxxxxxxx> wrote:
> On Tuesday 01 May 2012 15:05:30 Jonathan Lange wrote:
>> On Mon, Apr 30, 2012 at 5:28 PM, Jonathan Lange <jml@xxxxxxxxx> wrote:
>> ...
>>
>> >  * add a boolean parameter to the subscription that controls whether
>> > emails are sent
>>
>> This should have read "constructor" not "subscription".
>>
>> The corollary is that it would be stored as a field on Archive, and
>> that anyone would be able to set it on construction. Presumably only
>> PPA owners could change it. William jokingly suggested 'shut_up' as a
>> name for this field.
>
> So basically s/commercial/shut_up/
>

Yeah. Probably spelled as "suppress_subscription_notifications" or
something of that ilk. Would be simpler than 'commercial' in that it
would need fewer special permissions and wouldn't be so easy to
confuse with commercial_admin and things like that.

jml


Follow ups

References