launchpad-reviewers team mailing list archive

[Diogo Matsubara <matsubara@xxxxxxxxxxxxx>]

Diogo Matsubara has proposed merging lp:~matsubara/oops-tools/trivial into lp:~launchpad-pqm/oops-tools/trunk.

    Requested reviews:
    Diogo Matsubara (matsubara)


Non-informational OOPSes being wrongly categorized as informational only

-- 
https://code.launchpad.net/~matsubara/oops-tools/trivial/+merge/13378
Your team Launchpad code reviewers is subscribed to branch lp:~launchpad-pqm/oops-tools/trunk.

=== modified file 'oopstools/oops/summaries.py'
--- oopstools/oops/summaries.py	2009-10-13 15:41:12 +0000
+++ oopstools/oops/summaries.py	2009-10-14 19:55:18 +0000
@@ -172,7 +172,12 @@
                                      'InvalidBatchSizeError',
                                      'UnsupportedFeedFormat',
                                      'UntrustedReturnURL',
-                                     'UserRequestOops'] or oops.informational:
+                                     'UserRequestOops'] or (
+                                    # XXX matsubara: this will break summary
+                                    # generation using OopsMetaData. 
+                                    # OopsMetaData.informational attr is a 
+                                    # bool, not a str
+                                     oops.informational == 'True'):
             self.addOopsToSection(oops, section_id='user-generated-errors')
         elif oops.exception_type in ['UnicodeEncodeError', 'TypeError',
                                      'ProgrammingError'] and ('@@' in oops.url