launchpad-reviewers team mailing list archive

[Max Bowsher <maxb@xxxxxxx>]

Max Bowsher has proposed merging lp:~maxb/meta-lp-deps/no-sshd into lp:meta-lp-deps.

    Requested reviews:
    Launchpad code reviewers (launchpad-reviewers)


I ran the full testsuite without openssh-client/server installed.

Turns out we require openssh-client in *production*, to run ssh-vulnkey on newly added keys.

So I've amended the lp-deps and lp-dev-deps appropriately.
-- 
https://code.launchpad.net/~maxb/meta-lp-deps/no-sshd/+merge/16275
Your team Launchpad code reviewers is subscribed to branch lp:meta-lp-deps.

=== modified file 'debian/changelog'
--- debian/changelog	2009-12-16 10:02:58 +0000
+++ debian/changelog	2009-12-17 10:40:26 +0000
@@ -1,9 +1,13 @@
-launchpad-dependencies (0.61) lucid; urgency=low
+launchpad-dependencies (0.61) karmic; urgency=low
 
   * launchpad-developer-dependencies: Remove python-pullparser, which has been
     removed from Lucid and is not used.
+  * launchpad-developer-dependencies: Remove ssh, running a sshd is not
+    required.
+  * launchpad-dependencies: Add openssh-client, LP operationally shells out to
+    ssh-vulnkey when a user adds an SSH key.
 
- -- Max Bowsher <maxb@xxxxxxx>  Wed, 16 Dec 2009 10:02:15 +0000
+ -- Max Bowsher <maxb@xxxxxxx>  Thu, 17 Dec 2009 10:37:13 +0000
 
 launchpad-dependencies (0.60) karmic; urgency=low
 

=== modified file 'debian/control'
--- debian/control	2009-12-16 10:02:58 +0000
+++ debian/control	2009-12-17 10:40:26 +0000
@@ -18,7 +18,8 @@
   python-magic, geoip-data | geoip-data-city-lite,
   python-psycopg2 (>= 2.0.7+bzr361-0~CAT.8.04), python-pygments,
   python-support, python-openid, python2.5-pysqlite2, zlib1g-dev,
-  ca-certificates, python-pyrex, libapr1-dev, libsvn-dev
+  ca-certificates, python-pyrex, libapr1-dev, libsvn-dev,
+  openssh-client
 Recommends: launchpad-database-dependencies (= ${source:Version})
 Suggests:
 Description: Metapackage for dependencies of Launchpad
@@ -38,7 +39,7 @@
   launchpad-soyuz-dependencies (= ${source:Version}),
   exuberant-ctags, bzr-pqm, python-clientcookie,
   postgresql-doc-8.3, postgresql-autodoc, tidy,
-  python-codespeak-lib, pylint, ssh, mhonarc,
+  python-codespeak-lib, pylint, mhonarc,
   fakeroot, rsync, spidermonkey-bin, git-core, memcached,
   xvfb, firefox, xfonts-base
 Recommends: pyflakes