← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~maxb/meta-lp-deps/no-sshd into lp:meta-lp-deps

 

Review: Approve code
Thanks Max!

JFTR: I checked with Salgado and he's in agreement (just checked because I've been out of the loop of this discussion).

And for my own learning:

<noodles775> maxb: sorry, I'm not so familiar with the lp dependencies - is there a reason why you've not incremented the version to 0.62 and added a new changelog entry, rather than editing the 0.61 entry that you created with r67?

Is it simply because you're only removing an unneeded dependency, so it won't matter if users are stuck with the original 0.61 version?
-- 
https://code.edge.launchpad.net/~maxb/meta-lp-deps/no-sshd/+merge/16280
Your team Launchpad code reviewers is subscribed to branch lp:meta-lp-deps.



Follow ups

References