launchpad-reviewers team mailing list archive

[Gary Poster <gary.poster@xxxxxxxxxxxxx>]

Gary Poster has proposed merging lp:~gary/meta-lp-deps/geoiplite into lp:meta-lp-deps.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)


This simply adds developer dependecy on geoip-data-city-lite because it is necessary for the tests, as discovered by mthaddon when he was setting up a buildbot slave.
-- 
https://code.launchpad.net/~gary/meta-lp-deps/geoiplite/+merge/27381
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~gary/meta-lp-deps/geoiplite into lp:meta-lp-deps.

=== modified file 'debian/changelog'
--- debian/changelog	2010-06-10 15:29:17 +0000
+++ debian/changelog	2010-06-11 17:10:44 +0000
@@ -1,3 +1,10 @@
+launchpad-dependencies (0.74) lucid; urgency=low
+
+  * Make launchpad-developer-dependencies require geoip-data-city-lite
+    because it is necessary for the tests (the production data will not work).
+
+ -- Gary Poster (Gerbrand Poster IV) <gary.poster@xxxxxxxxxxxxx>  Fri, 11 Jun 2010 13:01:57 -0500
+
 launchpad-dependencies (0.73) lucid; urgency=low
 
   * Recommend python-boto (necessary for ec2). (LP: #591970) (Jelmer)

=== modified file 'debian/control'
--- debian/control	2010-06-10 15:29:17 +0000
+++ debian/control	2010-06-11 17:10:44 +0000
@@ -40,7 +40,7 @@
 Depends: launchpad-dependencies (= ${source:Version}),
   launchpad-database-dependencies (= ${source:Version}),
   launchpad-soyuz-dependencies (= ${source:Version}),
-  exuberant-ctags, bzr-pqm,
+  exuberant-ctags, bzr-pqm, geoip-data-city-lite,
   postgresql-doc-8.3, postgresql-autodoc, tidy,
   python-codespeak-lib, pylint, mhonarc, python-imaging (>= 1.1.7),
   fakeroot, rsync, spidermonkey-bin, git-core, memcached,