launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

The proposal to merge lp:~stevenk/launchpad/db-agent-getarchivesubscriptionurl into lp:launchpad/devel has been updated.

Description changed to:

The original MP for this change is https://code.edge.launchpad.net/~stevenk/launchpad/db-agent-getarchivesubscriptionurl/+merge/29191

This branch moves IArchive.getPrivateSourcesList() to IPerson.getArchiveSubscriptionURL(), continues to expose it via the API, and adds a requester argument to it as well as to .getArchiveSubscriptionURLs(), so we can do some checking of who is calling them.

It moves the tests for this out of xx-archive.txt, expands on them, and puts them into xx-archive.commercial.txt. It also cleans up the other tests that were using .getPrivateSourcesList(), and I fixed what looked to be a indent issue via drive-by.

An interdiff of the changes between this branch when it was reviewed on the original MP and now is at http://paste.ubuntu.com/462542/
-- 
https://code.launchpad.net/~stevenk/launchpad/db-agent-getarchivesubscriptionurl/+merge/29689
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/db-agent-getarchivesubscriptionurl into lp:launchpad/devel.